test: fix flaky test-performance-eventloopdelay #61629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was flaky because the histogram sampling might not have completed before the assertions ran. By using setImmediate before disabling the histogram and checking values, we give the event loop a chance to record final samples on slower systems. Also added an explicit check for histogram.count > 0 to provide a clearer error message if no samples are recorded. Refs: nodejs/reliability#1450
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61629 +/- ##
==========================================
- Coverage 89.76% 89.74% -0.02%
==========================================
Files 673 673
Lines 203945 203945
Branches 39191 39194 +3
==========================================
- Hits 183076 183040 -36
- Misses 13198 13233 +35
- Partials 7671 7672 +1 🚀 New features to boost your workflow:
|
legendecas
approved these changes
Feb 3, 2026
github-actions
bot
removed
the
request-ci
Collaborator
mcollina
added
author ready
anonrig
approved these changes
Feb 4, 2026
mcollina
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 87e8e8b |
aduh95
pushed a commit
that referenced
this pull request
Feb 8, 2026
The test was flaky because the histogram sampling might not have completed before the assertions ran. By using setImmediate before disabling the histogram and checking values, we give the event loop a chance to record final samples on slower systems. Also added an explicit check for histogram.count > 0 to provide a clearer error message if no samples are recorded. Refs: nodejs/reliability#1450 PR-URL: #61629 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
test/sequential/test-performance-eventloopdelay.jsProblem
The test was flaky because the histogram sampling might not have completed
before the assertions ran. The assertion
assert(histogram.min > 0)couldfail if no samples were recorded yet.
Solution
setImmediate(common.mustCall(() => {...}))togive the event loop a chance to record final samples before checking
histogram.count > 0to provide a clearererror message if no samples are recorded
Verification
Verified with
python3 tools/test.py --repeat 50without failures.Refs: nodejs/reliability#1450